Skip to content

Fix very rare deadlock #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix very rare deadlock #1771

merged 1 commit into from
Feb 12, 2025

Conversation

lukebakken
Copy link
Collaborator

Fixes #1751

Attempt to fix deadlock by waiting on channel dispatcher first, then channel reader.

@lukebakken lukebakken added this to the 7.1.0 milestone Jan 22, 2025
@lukebakken lukebakken self-assigned this Jan 22, 2025
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1751 branch from b2025e2 to 3fff3aa Compare February 5, 2025 15:21
@lukebakken lukebakken marked this pull request as ready for review February 12, 2025 19:55
Fixes #1751

* Drain and log pending work when AsyncConsumerDispatcher loop ends.
* Make quiescing thread safe.
* Ensure that dequeued RPC continuations are always disposed. Found by @DenisMayorko
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent deadlock when closing a channel using CloseAsync in 7.x
1 participant